DNSTools v2 Beta

TheDP · April 5, 2021, 12:37pm

Looking good mate

luki9100 · April 15, 2021, 12:51pm

It shows verry funny results if you enter a subdomain, which uses an internal IP address.
For example my internal Grafana Domain:
—8<—
~$ dig a grafana.luki9100.tech +short
192.168.178.212
—8<—

Daniel · April 15, 2021, 10:20pm

LOL. I see the same result at the command-line when I traceroute grafana.luki9100.tech.

It’s actually supposed to block private IPs:

github.com

Daniel15/dnstools/blob/dd771ac717e6f2861816344584200c7afd1e77ed/src/DnsTools.Worker/Utils/Hostname.cs#L39-L42


      
          			if (ip.IsPrivate())
          			{
          				throw new ArgumentException("Private IPs are not allowed");
          			}

github.com

Daniel15/dnstools/blob/dd771ac717e6f2861816344584200c7afd1e77ed/src/DnsTools.Worker/Extensions/IpExtensions.cs#L10-L21


      
          		public static bool IsPrivate(this IPAddress address)
          		{
          			var bytes = address.GetAddressBytes();
          			return bytes[0] switch
          			{
          				10 => true,
          				127 => true,
          				172 => (bytes[1] >= 16 && bytes[1] < 32),
          				192 => (bytes[1] == 168),
          				_ => false
          			};
          		}

and it does block them if you enter the IP directly, but not if you enter a hostname that resolves to a private IP <_<

I’ll fix it soon.